Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuerydslPredicateBuilder.getPredicate() to support multiple Ops [DATACMNS-1808] #2222

Open
spring-projects-issues opened this issue Oct 3, 2020 · 1 comment
Assignees
Labels
in: mapping in: repository type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Oct 3, 2020

deepesh-verma opened DATACMNS-1808 and commented

The current implementation of the QuerydslPredicateArgumentResolver, which in turn uses the QuerydslPredicateBuilder.getPredicate() method, supports Precdicate building by parsing request parameters as below - 

?name=deepesh&age=28&language=hindi,english

Can this be enhanced to support the below request parameters, and allow user the pass the com.querydsl.core.types.Ops values as below - 

?name=deepesh,EQ&age=25,GT&language=[hindi,english],IN

No further details from DATACMNS-1808

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Oct 4, 2020

deepesh-verma commented

I have a draft PR open with the first draft of changes. I have made sure that all the existing test cases are passing. Will update it with more test cases backing my changes and do a round of cleanup, before I make this ready for review.

Oliver Drotbohm, It will be great if you can review this and let me know if this seems like something which might be a fine addition, so that I can work further on it.

#469

@spring-projects-issues spring-projects-issues added in: repository type: enhancement in: mapping labels Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: mapping in: repository type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants