Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of findAll(…) methods to return Iterable rather than List. [DATACMNS-21] #502

Closed
spring-projects-issues opened this issue Mar 10, 2011 · 0 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Mar 10, 2011

Oliver Drotbohm opened DATACMNS-21 and commented

Some datastores (e.g. Neo4J) allow delaying the actual data retrieval by returning Iterable instead of Collection types. This can significantly improve performance especially when working with large result sets. As our findAll(…) methods all return List instances we force eager retrieval of the data in any case.

So we could change the return types of findAll(…) methods for Repository and have store specific ones override those methods to return List again in case these stores can only return Collection instances anyway (e.g. JPA, Mongo)


Affects: 1.0 M3

Referenced from: commits spring-projects/spring-data-mongodb@d824ed7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants