New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor. #86

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@thomasdarimont
Collaborator

thomasdarimont commented Jun 12, 2014

DATACMNS-518 - Spring Data Infinite Loop in HashMap in PreferredConstructor.

We now synchronise the (seldom) writes to the isPropertyParameterCache HM in PreferredConstructor via a ReadWriteLock. We could as well have used a CHM here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

thomasdarimont added a commit that referenced this pull request Jun 12, 2014

DATACMNS-518 - Spring Data Infinite Loop in HashMap in PreferredConst…
…ructor.

We now synchronise the (seldom) writes to the isPropertyParameterCache HM in PreferredConstructor via a ReadWriteLock. We could as well have used a CHM here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

Original pull request: #86.

@thomasdarimont thomasdarimont changed the title from DATACMNS-518 - Spring Data Infinite Loop in HashMap in PreferredConstructor. to DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor. Jun 12, 2014

DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor.
We now synchronise the (seldom) writes to the isPropertyParameterCache HM in PreferredConstructor via a ReadWriteLock. We could as well have used a CHM here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

Original pull request: #86.

thomasdarimont added a commit that referenced this pull request Jun 26, 2014

DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor.
We now synchronize the (seldom) writes to the isPropertyParameterCache HashMap in PreferredConstructor via a ReadWriteLock. We could as well have used a ConcurrentHashMap here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

Original pull request: #86.

thomasdarimont added a commit that referenced this pull request Jun 26, 2014

DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor.
We now synchronize the (seldom) writes to the isPropertyParameterCache HashMap in PreferredConstructor via a ReadWriteLock. We could as well have used a ConcurrentHashMap here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

Original pull request: #86.

thomasdarimont added a commit that referenced this pull request Jun 26, 2014

DATACMNS-518 - Avoid potential infinite loops in PreferredConstructor.
We now synchronize the (seldom) writes to the isPropertyParameterCache HashMap in PreferredConstructor via a ReadWriteLock. We could as well have used a ConcurrentHashMap here without the need for manual locking but this would potentially waste memory for a mostly read-only data structure. We also anticipate potential multiple writes for the same property.

Original pull request: #86.

@olivergierke olivergierke deleted the issue/DATACMNS-518 branch Jun 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment