DATACMNS-557 - Add support for custom implementations in CDI #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks decent, Mark. I think I can take it from there. Would you mind signing the CLA and report the confirmation number back here? |
|
Cool, thank you. The confirmation no is 88820140806073332 |
|
Brilliant, thanks. I've polished the stuff slightly and have it ready to push. I'll take the test cases from your PR in the JPA module to adapt it right away. |
odrotbohm
pushed a commit
that referenced
this pull request
Aug 7, 2014
…tructure. The CDI extension now discovers a custom implementation class similarly to the detection when using Spring Data in a Spring container. Extracted the custom implementation detection for re-use. The CDI extension discovers the potentially available bean and hands it to the CdiRepositoryBean for further usage. Implementations should implement the extended variant of the create(…) method we introduce with this commit to be able to forward the resolved custom implementation bean. Original pull request: #92.
odrotbohm
added a commit
that referenced
this pull request
Aug 7, 2014
Renamed CdiRepositoryConfigurationSource to CdiRepositoryConfiguration. Turned anonymous inner default implementation into dedicated enum to avoid repeated instantiation. Changed the CdiRepositoryBean to rather take a Bean instance of the custom implementation instead of the resolved object to make sure both instances (the custom implementation and the repository proxy) are instantiated at the same time. Fixed imports. Some early returns to avoid unnecessary nesting. Adapted architecture description to allow CDI module accessing the configuration module. Related pull request: #92.
|
That's applied, JPA parts coming ASAP. |
odrotbohm
changed the title
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for further adoption in the spring-data-* modules.