Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some repository methods ignore ScanConsistency annotation [DATACOUCH-585] #893

Closed
spring-projects-issues opened this issue Jul 16, 2020 · 2 comments
Assignees
Labels
type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jul 16, 2020

Michael Reiche opened DATACOUCH-585 and commented

SimpleReactiveCouchbaseRepository count() is missing the consistentWith(buildQueryScanConsistency() which can be found in findAll(Query q).

consistentWith() is not relevant to any other queries which operate on the id (findById(), findAllById(),  upsertById, deleteById ).    ReactiveRemoveByQuery already leverages consistentWith(). 


Referenced from: pull request #247

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 21, 2020

Michael Reiche commented

This is fixed for count() in 4.0.2. but it needs additional work in ReactiveN1qlRepositoryQueryExecutor and N1qlRepositoryQueryExecutor for processing ScanConsistency (and WithConsistency) annotations on countByxxxx() queries. 

@mikereiche
Copy link
Collaborator

@mikereiche mikereiche commented Aug 14, 2021

N1qlRepositoryQueryExecutor has been deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants