Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATACOUCH-245: QBE support #125

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
6 participants
@bsubhashni
Copy link
Contributor

commented Dec 13, 2016

No description provided.

odrotbohm and others added some commits Nov 23, 2016

DATACOUCH-246 - Projections support for query derivation.
Used the result processor projecting information to just fetch the selected fields and again to post process results to projection object/interfaces.

Added test for projection using DTO.

Original pull request: #122.
DATACOUCH-246 - Polishing.
Removed the dynamic return type obtained from the ResultProcessor held in a query implementation field as this breaks thread safety. We now hand the type to read into the execution methods.

Adapted test cases accordingly and removed a bit of mocking.

Original pull request: #122.
DATACOUCH-261 - Register CouchbaseRepositoryFactory in spring.factories.
This is required for the switch in support for multi-store detection.

Related ticket: DATACMNS-952.
for(Party p:parties) {
count +=1;
}
assertTrue(count == 14);

This comment has been minimized.

Copy link
@simonbasle

simonbasle Dec 14, 2016

Contributor

prefer the Assert.assertEquals assertion which has a more descriptive message in case of error

This comment has been minimized.

Copy link
@simonbasle

simonbasle Dec 14, 2016

Contributor

in general, in all these tests try to avoid assertTrue and assertFalse other than on boolean fields, the more specific assertions will usually display the unexpected value, etc...

This comment has been minimized.

Copy link
@bsubhashni

bsubhashni Dec 14, 2016

Author Contributor

Yes makes sense, fixed

Statement st = selectFrom.where(whereCriteria).limit(1);
ScanConsistency consistency = getCouchbaseOperations().getDefaultConsistency().n1qlConsistency();
N1qlQuery query = N1qlQuery.simple(st, N1qlParams.build().consistency(consistency));
return getCouchbaseOperations().findByN1QL(query, example.getProbeType()).get(0);

This comment has been minimized.

Copy link
@simonbasle

simonbasle Dec 14, 2016

Contributor

need either null safety or index out of bounds safety check on the get(0)

This comment has been minimized.

Copy link
@bsubhashni

bsubhashni Dec 14, 2016

Author Contributor

Thanks good catch :) Fixed it.

odrotbohm and others added some commits Dec 15, 2016

DATACOUCH-251 - Wrap base where criteria with parenthesis for OR expr…
…essions.

Base criteria for the query should be wrapped before adding the entity filter criteria so the priority of filtering is clear.
@bsubhashni

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2017

@olivergierke, It'd be great to get this reviewed and merged. Thanks.

@bsubhashni bsubhashni force-pushed the spring-projects:master branch 3 times, most recently from 863cf8c to ebe570b Feb 5, 2017

@schauder schauder force-pushed the spring-projects:master branch from b09445a to dc0f552 Mar 30, 2017

@bsubhashni bsubhashni force-pushed the spring-projects:master branch from 692a1e1 to 6429dca Apr 6, 2017

@davidkelly

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2019

Closing for now as there are many conflicts. @bsubhashni if you would like to resolve the conflicts and reopen, we can get it re-reviewed and merged

@davidkelly davidkelly closed this Jun 28, 2019

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jun 28, 2019

@bsubhashni Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jun 28, 2019

@bsubhashni Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.