Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for geo_shape type entity properties [DATAES-930] #1505

Closed
spring-projects-issues opened this issue Sep 19, 2020 · 0 comments
Closed
Labels
in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Sep 19, 2020

sothawo opened DATAES-930 and commented

We should introduce geo types that can be used as properties of type geo_shape

There are two implementations we could use/adapt. The first is from hefay's PR (#186), the GeoShape... classes. The second comes from the spring-data-mongodb project (https://github.com/spring-projects/spring-data-mongodb/tree/master/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/geo), here the GeoJson... classes.

I think that the GeoJson classes from spring-data-mongodb are easier to integrate, because the can be processed with the MappingElastcisearchConverter, whereas the GeoShape classes would need to be adapted as they were built to be converted by a Jackson module (which we do not use anymore in Spring Data Elasticsearch)


Issue Links:

  • DATAES-929 Support geo_shape field type field type
    ("depends on")
  • DATAES-931 Add query support for geo shape queries
    ("is depended on by")
  • DATAES-169 Geo Shape support

Referenced from: pull request #531

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: mapping Mapping and conversion infrastructure labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant