Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeforeConvertCallback should be called before index query is built [DATAES-972] #1546

Closed
spring-projects-issues opened this issue Nov 11, 2020 · 0 comments
Closed

BeforeConvertCallback should be called before index query is built [DATAES-972] #1546

spring-projects-issues opened this issue Nov 11, 2020 · 0 comments
Labels
in: core Issues in core support type: bug A general bug
Milestone
4.2 M1 (2021.0.0)

Comments

@spring-projects-issues
Copy link

kkonrad opened DATAES-972 and commented

When I tried to set JoinField in BeforeConvertCallback handler I noticed it didn't fully work as EntityOperations.getRouting was called before.

sothawo took a look into this and noticed that currently callback is invoked after index query was built. Probably it should be other way round

Affects: 4.1 GA (2020.0.0)

Referenced from: pull request #555

Backported to: 4.1.2 (2020.0.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Milestone
4.2 M1 (2021.0.0)
Development

No branches or pull requests
1 participant
@spring-projects-issues