Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include total, other and missing count in TermResult [DATAES-127] #702

Closed
spring-projects-issues opened this issue Sep 1, 2014 · 2 comments
Closed

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 1, 2014

Matija Obreza opened DATAES-127 and commented

TermsFacet in elasticsearch provides totalCount, otherCount and missingCount.

These are not included in DefaultFacetMapper when constructing TermResult


Affects: 1.0.4 (Dijkstra SR4)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 19, 2014

Mohsin Husen commented

Thanks for the PR.

Improvement on term facet looks totally fine. but the branch you have used is 1.0.x due to which there are conflicts while merging your changes to master.

can you please initiate PR against master(default) branch ?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 20, 2015

Artur Konczak commented

PR - rebased and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.