Adapt to API changes in mapping subsystem [DATAES-369]

[spring-projects-issues]

Mark Paluch opened DATAES-369 and commented

Adopt code to changes related to Optional removal in mapping and convert packages in Spring Data Commons

---

Affects: 3.0 M4 (Kay)

Issue Links:

• DATACMNS-1101 Improve mapping performance caused by overuse of Optional and Stream

[spring-projects-issues]

Mahesh D Dhola commented

Recent merge on master from issue/DATAES-369 branch is causing compilation failure.
I was referencing snapshot lib which got recently updated based on latest changes regarding DATAES-369 and when I run my project it fails.
Then I tried getting source directly but I see it's not be compiled. I am wondering how come snapshot jar got released with such broken changes!
BTW, to resolve this issue, pom needs to be updated with <springdata.commons>2.0.0.DATACMNS-1101-SNAPSHOT</springdata.commons>

[spring-projects-issues]

Mark Paluch commented

Thanks IndianOcean for noticing the broken build. The Elasticsearch build is now broken because of an additional compile-time dependency in Spring Data Commons. Elasticsearch is very strict about duplicate classes hence it fails upon test execution. Subscribe to DATACMNS-1104 to retry the build once the mentioned ticket is resolved

[spring-projects-issues]

Mahesh D Dhola commented

Thanks Mark. I've changed pom entry for spring data commons version to the following which worked fine for me in my local machine.
from
<springdata.commons>2.0.0.BUILD-SNAPSHOT</springdata.commons>
to
<springdata.commons>2.0.0.DATACMNS-1101-SNAPSHOT</springdata.commons>
BTW, it was not test execution failure but compilation failure due to changes made in APIs in view of new spring data commons.
I'll wait for the spring-data-elasticsearch snapshot to be updated with latest working code until I've switched to M4 for my project