Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAES-372 Support highlighting via annotation #185

Open
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@zzt93
Copy link
Contributor

commented Aug 2, 2017

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

zzt93 added some commits Jul 14, 2017

DATAES-372 - Support highlighting via annotation
Add highlight annotation and test case.
Add highlight annotation extraction.
DATAES-372 - Support highlighting via annotation
Add highlight mapper;
Change string query;
DATAES-372 - Support highlighting via annotation
Add highlight mapper basic implementation.
Change string query to use search query when using highlight.
DATAES-372 - Support highlighting via annotation
Finish highlight mapper implementation via reflection.
Add more util functions in `ElastcisearchOperation`.
Add mapper needed field in annotation.
Change string query to use search query when using highlight.
Merge remote-tracking branch 'origin/highlightAnnotation' into highli…
…ghtAnnotation

# Conflicts:
#	src/main/java/org/springframework/data/elasticsearch/core/HighlightMapper.java
#	src/main/java/org/springframework/data/elasticsearch/repository/query/ElasticsearchQueryMethod.java
#	src/main/java/org/springframework/data/elasticsearch/repository/query/ElasticsearchStringQuery.java
DATAES-372 - Support highlighting via annotation
Refactor CriteriaQuery conversion.
Add implementation highlight support for part query.
DATAES-372 - Support highlighting via annotation
Add more test cases for test highlight annotation.
Add repo test.
Fix the bug of xml settings.
DATAES-372 - Support highlighting via annotation
Change the highlight annotation default value.
Fix the bug of search query highlight builder.
Add more corner case checking in mapper.
Add more test cases.
DATAES-372 - Support highlighting via annotation
Fix the bug of wrong counts of hits;
Add more tests.

@odrotbohm odrotbohm force-pushed the spring-projects:master branch from 020b5e1 to ba3eba5 Jun 18, 2018

@mp911de mp911de force-pushed the spring-projects:master branch from 01cda35 to b6fa4c8 May 6, 2019

@sothawo

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Do you think you can update this PR to the current master?

@sothawo sothawo self-assigned this Jun 27, 2019

@zzt93

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2019

I will try, may take a while to recall the old code logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.