Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAES-456+387 - re-enable dynamic index name evaluation. #221

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
4 participants
@sylvainlaurent
Copy link
Contributor

commented Oct 18, 2018

fix for https://jira.spring.io/browse/DATAES-456
and
https://jira.spring.io/browse/DATAES-387

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@sylvainlaurent sylvainlaurent changed the title DATAES-456 - re-enable dynamic index name evaluation. DATAES-456+387 - re-enable dynamic index name evaluation. Oct 18, 2018

@akonczak

This comment has been minimized.

Copy link
Collaborator

commented Nov 9, 2018

Hi @sylvainlaurent - would you be able to complete all checks from the guidance form

@xhaggi

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

BTW please rebase your branch against the master to solve the conflicts

@mp911de mp911de force-pushed the spring-projects:master branch from 01cda35 to b6fa4c8 May 6, 2019

@sylvainlaurent sylvainlaurent force-pushed the sylvainlaurent:bugfix/DATAES-456 branch from 9d4402e to 981d577 Jun 26, 2019

@sylvainlaurent sylvainlaurent force-pushed the sylvainlaurent:bugfix/DATAES-456 branch from 981d577 to cc4081b Jun 26, 2019

@sylvainlaurent

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

hello @xhaggi , I rebased against master (57ba74e as I write)

@sothawo sothawo merged commit bf49482 into spring-projects:master Jun 27, 2019

1 check passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
@sothawo

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

This PR has been merged, thank you for the contribution!

@sylvainlaurent sylvainlaurent deleted the sylvainlaurent:bugfix/DATAES-456 branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.