Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAES-541: Fix ElasticsearchRestTemplateTests alias handling #242

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@gonzalad
Copy link

commented Mar 5, 2019

This commit fixes:

  • IllegalArgumentException on ElasticsearchRestTemplate#removeAlias
  • NoSuchElementException on ElasticsearchRestTemplate#queryForAlias when
    no alias exists.

Note: I've moved the tests in AliasTests to ElasticsearchRestTemplate so they are executed for both ElasticsearchRestTemplate and ElasticsearchTemplate.

Make sure that:

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Adrian.Gonzalez and others added some commits Mar 5, 2019

Adrian.Gonzalez Adrian.Gonzalez
DATAES-541: Fix ElasticsearchRestTemplateTests alias handling
This commit fixes:

* IllegalArgumentException on ElasticsearchRestTemplate#removeAlias
* NoSuchElementException on ElasticsearchRestTemplate#queryForAlias when
  no alias exists.

@mp911de mp911de force-pushed the spring-projects:master branch from 01cda35 to b6fa4c8 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.