Fix blocking code for index and mapping creation in reactive repo - #2644
Closed
Arooba-git wants to merge 1 commit into
Closed
Arooba-git wants to merge 1 commit into
Arooba-git wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Collaborator
|
Before creating a PR, please create an issue to discuss a problem. What do you mean by failing tests? I know that there are uses of block() in the reactive tests, but none of these are causing tests to fail. Neither locally nor in the build pipeline |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! :)
Currently the test cases for reactive modules are mostly failing due to prevalence of the
.block()operator in the test cases. However this PR addresses the blocking code in themainrepo:The
createIndexAndMappingIfNeededmethod in theSimpleReactiveElasticsearchRepositoryhave been slightly modified to remove the.blockoperator, and this eliminates most of the exceptions related to blocking code. The test cases were run before and after the fix and some test cases are now passing (others still failing of course due to the.blockoperator in the test case itself):Before
After
