DATAGRAPH-752 - Add Spring Data Neo4j 4 Example to Spring-Data-Examples. #129
Conversation
Spring Boot 1.3.0 M2 -> 1.3.0 M4 Spring Framework 4.2.0 -> 4.2.1
| <version>${spring-data-neo4j.version}</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
What's the reason we need these test JARs in the classpath? I would've expected to only see the Spring Data Neo4j dependency. Anything I am missing?
There was a problem hiding this comment.
They are needed for the in-memory server, and test-jar dependencies are not resolved transitively by maven :(
There was a problem hiding this comment.
But which of the two is it then? Does it make sense to make them a dedicated artifact? It just looks weird having to refer to something test related from a non-test scope.
There was a problem hiding this comment.
We need them all unfortunately. The spring-data-neo4j test-jar contains the InProcessServer and the others contain the test utilities and TestServer from neo4j-ogm
There was a problem hiding this comment.
Actually we can clean it up a bit, which I did here: #130
We can add an (JIRA) issue for a separate test module both in the neo4j-ogm and in spring-data-neo4j-4, should be pretty straightforward to add, not sure we can make it in time for 4.0.GA though?
Switched to milestone version of Spring Data Neo4j. Used Lombok in domain types. Used assertThat(…) matchers in test case for consistency. Inlined Spring configuration into test case. Upgraded to Lombok 1.16.6 along the way. Fixed indentation in pom.xml files to use tabs instead of spaces. Original pull requests: #129, #130.
|
Polished and merged (see #131). |
No description provided.