Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include geode redis module due to upgrading geode to 1.9.0 [DATAGEODE-211] #255

Closed
spring-projects-issues opened this issue Jul 19, 2019 · 2 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jul 19, 2019

jmwaniki opened DATAGEODE-211 and commented

Due to upgrading to apache geode 1.9.0, we need to include geode redis as a separate dependency. Otherwise we can document the dependency will be required to use the @EnableRedisServer annotation provided by the spring-geode-starter project


Affects: 2.2 RC1 (Moore)

Referenced from: commits 1d07533, 597a6d5

Backported to: 2.2.2 (Moore SR2)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 16, 2019

yozaner1324 commented

I did some investigating and determined that you do in fact need to have org.apache.geode:geode-redis on the classpath to use the @EnableRedisServer annotation. This is documented already here: https://docs.spring.io/spring-data/geode/docs/current/reference/html/#bootstap-annotations-quickstart-redisserver

 

It would make sense not to have this annotation available without the required dependency, so maybe the solution is to move the annotation to a submodule, like org.springframework.geode:geode-redis, that would then pull in org.apache.geode:geode-redis.

 

While experimenting with the Redis adapter, I had issues putting/getting data to/from Geode with a Redis client because of this issue: https://issues.apache.org/jira/browse/GEODE-2469. This is a fairly major issue but is not being fixed, which leads me to believe that the Redis adapter is not being supported by anyone at the moment, so another solution may be simply to deprecate the annotation. 

 

Note that the issues I experienced occur both when starting Geode with Spring and using the @EnableRedisServer annotation, and when starting Geode through Gfsh as described here: https://geode.apache.org/docs/guide/11/tools_modules/redis_adapter.html

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 14, 2019

John Blum commented

We cannot include the geode-redis dependency in SDG as a non-optional, compile-time (therefore, required) dependency since the geode-redis module declares Netty as a compile-time dependency.

The primary reason for this is that Netty has special meaning in a Spring Boot context, specifically with respect to auto-configuration when Netty is on the application classpath.

As the documentation indicates, users must explicitly declare the geode-redis module on the application classpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants