Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a PoolResolver strategy interface to resolve Pool instances and provide a layer of indirection between SDG and Apache Geode's static PoolManager class [DATAGEODE-281] #326

spring-projects-issues opened this issue Dec 5, 2019 · 0 comments


Copy link

@spring-projects-issues spring-projects-issues commented Dec 5, 2019

John Blum opened DATAGEODE-281 and commented

Because the Apache Geode PoolManager class implementation largely consists of statics, this introduces very serious consequences for SDG's design and functionality, which in many cases forces SDG to use "internal" Geode APIs and prevents things from being mocked properly. 

By introducing a PoolResolver interface, and an implementation based on Geode's PoolManager class, SDG can indirectly resolve required/necessary Pool instances in a more agnostic way and conducive manner for testing

Affects: 2.1.14 (Lovelace SR14), 2.2.3 (Moore SR3)

Reference URL:

Backported to: 2.2.4 (Moore SR4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants