Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create composed annotations from some of the common, logically related SDG annotations [DATAGEODE-365] #412

Open
spring-projects-issues opened this issue Aug 31, 2020 · 2 comments
Assignees
Labels
in: configuration Issues with configuration status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

John Blum opened DATAGEODE-365 and commented

This development task will add new SDG annotations, such as:

@ManagingLocatorCacheServerApplication

Which will be meta-annotated with:

  • @CacheServerApplication
  • @EnableLocator
  • @EnableManager

And expose appropriate/common configuration attributes through aliasing.

Additionally, we will provide other "composed annotations", for example:

@EnablePersistentApplication

Which would be meta-annotated with:

  • @EnableEntityDefinedRegions
  • @EnableGemfireRepositories
  • @EnablePdx

No further details from DATAGEODE-365

@spring-projects-issues
Copy link
Author

John Blum commented

This would effectively simplify the following:

@CacheServerApplication
@EnableLocator
@EnableManager(start = true)
@EnableEntityDefinedRegions(basePackageClasses = NonEntityPointer.class)
@EnableGemfireRepositories(basePackageClasses = NonRepositoryPointer.class)
@EnablePdx
class MySpringGeodeApplicationConfiguration { ... }

To:

@ManagingLocatorCacheServerApplication(manager-start = true)
@EnablePersistentApplication(entityBasePackageClasses = ..., repositoryBasePackageClasses = ...)
class MySpringGeodeApplicationConfiguration { ... }

@spring-projects-issues
Copy link
Author

John Blum commented

Composed Annotation naming as well as which Composed Annotations we will provide OOTB is subject to feedback

@spring-projects-issues spring-projects-issues added in: configuration Issues with configuration type: enhancement A general enhancement labels Dec 31, 2020
@jxblum jxblum added the status: pending-design-work Needs design work before any code can be developed label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: configuration Issues with configuration status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants