Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: query hints not applied to count queries for QueryDSL [DATAJPA-1087] #1428

Closed
spring-projects-issues opened this issue Apr 4, 2017 · 1 comment
Assignees
Labels
type: bug
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Apr 4, 2017

Jon Kranes opened DATAJPA-1087 and commented

Query hints added to QueryDSL repositories via the @QueryHints annotation were working for count queries in version 1.10.4 but are no longer applied as of version 1.10.5.

In org.springframework.data.jpa.repository.support.QueryDslJpaRepository, a change was made in version 1.10.5 so that a new method, createCountQuery() is now called when creating the count query, whereas previously the createQuery() method was called. The new createCountQuery() method disregards any query hints


Affects: 1.10.8 (Hopper SR8)

Issue Links:

  • DATAJPA-790 org.hibernate.QueryException when applying @EntityGraph on (Querydsl) findAll(Predicate, Pageable) method

Referenced from: pull request #195

Backported to: 1.11.2 (Ingalls SR2), 1.10.9 (Hopper SR9)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 12, 2017

Christoph Strobl commented

PR#195 preserves binary comparability can be applied to the 1.x line (1.10.x, 1.11.x and 1.12.x).

PR#196 is for 2.x (current master) changing some method signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants