Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableJpaAuditing: JavaDoc references joda.time instead of java.time [DATAJPA-1803] #2095

Closed
spring-projects-issues opened this issue Oct 21, 2020 · 1 comment

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Oct 21, 2020

Malte Mauelshagen opened DATAJPA-1803 and commented

The JavaDoc for EnableJpaAuditing#dateTimeProviderRef reads:

/**
 * Configures a {@link DateTimeProvider} bean name that allows customizing the {@link org.joda.time.DateTime} to be
 * used for setting creation and modification dates.
 *
 * @return
 */

which is not correct.

Instead of

org.joda.time.DateTime

it should be

java.time.temporal.TemporalAccessor

See DateTimeProvider:

public interface DateTimeProvider {

 /**
 * Returns the current time to be used as modification or creation date.
 *
 * @return
 */
 Optional<TemporalAccessor> getNow();
}

Referenced from: pull request #432

Backported to: 2.3.5 (Neumann SR5), 2.2.11 (Moore SR11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.