Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJPA-1277 - Additional extension point for simple jpa repository #254

Conversation

Projects
None yet
2 participants
@androidbod
Copy link

commented Feb 28, 2018

  • made CriteriaQuery building for methods: "getQuery" and "getCountQuery" more extensible (protected methods extracted)
  • allows for generic query modification while using the core SimpleJpaRepository functionality
  • can reuse more logic from SimpleJpaRepository on extensions/derivations of this class
  • feedback welcome
  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
    Well - this was just a refactoring - not entirely sure what test cases I was supposed to add (suggestions are very welcome here)
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Thomas Zirke added some commits Feb 28, 2018

Thomas Zirke
DATAJPA-1277
- made criteriaquery building for getQuery and getCountQuery methods extensable
- allows for generic query modification while using the SimpleJpaRepository functionality (OO Extensability)
- feedback welcome
Thomas Zirke
DATAJPS-1277
- applied spring code formatter according to JIRA ticket template instruction(s)
Thomas Zirke
DATAJPA-1277
- added myself as an author
Thomas Zirke
DATAJPA-1277
- author changed to match with account name
@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Feb 28, 2018

@androidbod Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@androidbod

This comment has been minimized.

Copy link
Author

commented Feb 28, 2018

Not sure if the minor refactoring I did within this feature branch requires me to sign the contributor license agreement. after all, i just rearranged a bit of existing code :-)

@odrotbohm odrotbohm changed the title Feature/datajpa 1277 additional extension point for simple jpa repository DATAJPA-1277 - Additional extension point for simple jpa repository Feb 28, 2018

Thomas Zirke
DATAJPA-1277
- reperformed refactoring adhering to Spring code style guidelines
-- IntelliJ somehow managed to take the source, throw it in a bag, shake well and produce completely reformatted and rearranged code - tried to fix that manually

@schauder schauder force-pushed the spring-projects:master branch from e164784 to 01e36db Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.