Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJPA-1061 - Fix Sorting doesn't work for field alias. #276

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@GregoireDruant
Copy link
Contributor

commented May 17, 2018

Extract field aliases in QueryUtils and add them in the set of possible sort criterias, to enable the possibility to sort query results based on fields' aliases.

  • [*] You have read the Spring Data contribution guidelines.
  • [*] There is a ticket in the bug tracker for the project in our JIRA.
  • [*] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [*] You submit test cases (unit or integration tests) that back your changes.
  • [*] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
DATAJPA-1061 - Fix Sorting doesn't work for field alias.
Extract field aliases in QueryUtils and add them in the set of possible sort criterias
@pivotal-issuemaster

This comment has been minimized.

Copy link

commented May 17, 2018

@GregoireDruant Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented May 17, 2018

@GregoireDruant Thank you for signing the Contributor License Agreement!

@schauder schauder force-pushed the spring-projects:master branch from e164784 to 01e36db Nov 1, 2018

@rafaesc

This comment has been minimized.

Copy link

commented Nov 16, 2018

@dsyer is it possible review this PR?

I have this problem.

@rogiller

This comment has been minimized.

Copy link

commented Jun 20, 2019

What is the status of this PR? When can it be merged?

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Sorting now works with field aliases.
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Polishing.
Tweaked the formatting and the naming of variables.

Original pull request: #276.

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Sorting now works with field aliases.
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Polishing.
Tweaked the formatting and the naming of variables.

Original pull request: #276.

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Sorting now works with field aliases.
Extract field aliases in QueryUtils and add them in the set of possible sort criteria.

Original pull request: #276.

schauder added a commit that referenced this pull request Jun 24, 2019

DATAJPA-1061 - Polishing.
Tweaked the formatting and the naming of variables.

Original pull request: #276.
@schauder

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

This is polished, rebased onto master and backported.

Thanks for the patience.

@schauder schauder closed this Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.