Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJPA-1368 - Register ExposeRepositoryInvocationInterceptor to isolate repository method call exposure. #280

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@mp911de
Copy link
Member

commented Jul 3, 2018

We now ship and register ExposeRepositoryInvocationInterceptor to expose proxy method invocations without interfering with ExposeInvocationInterceptor. ExposeRepositoryInvocationInterceptor is a copy of ExposeInvocationInterceptor that holds its own instance of the invoked method and that is isolated so no other component can affect the exposure of the invoked method.

Interceptors in the invocation chain can invoke methods on proxied objects (e.g. proxied TransactionManager) which override the invoked proxied method as ExposeInvocationInterceptor is a singleton. We previously lost the invoked method details.


Related ticket: DATAJPA-1368.

@mp911de mp911de force-pushed the issue/DATAJPA-1368 branch from 8510a2c to 5ee17dd Jul 19, 2018

@schauder schauder force-pushed the master branch from e164784 to 01e36db Nov 1, 2018

mp911de added some commits Jul 3, 2018

DATAJPA-1368 - Register ExposeRepositoryInvocationInterceptor to isol…
…ate repository method call exposure.

We now ship and register ExposeRepositoryInvocationInterceptor to expose proxy method invocations without interfering with ExposeInvocationInterceptor. ExposeRepositoryInvocationInterceptor is a copy of ExposeInvocationInterceptor that holds its own instance of the invoked method and that is isolated so no other component can affect exposure of the invoked method.

Interceptors in the invocation chain can invoke methods on proxied objects (e.g. proxied TransactionManager) which override the invoked proxied method as ExposeInvocationInterceptor is a singleton. We previously lost the invoked method details.

@schauder schauder force-pushed the issue/DATAJPA-1368 branch from f1b23dc to 4269f47 Jul 1, 2019

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Register ExposeRepositoryInvocationInterceptor to isol…
…ate repository method call exposure.

We now ship and register ExposeRepositoryInvocationInterceptor to expose proxy method invocations without interfering with ExposeInvocationInterceptor.
ExposeRepositoryInvocationInterceptor is a copy of ExposeInvocationInterceptor that holds its own instance of the invoked method and that is isolated so no other component can affect exposure of the invoked method.

Interceptors in the invocation chain can invoke methods on proxied objects (e.g. proxied TransactionManager) which override the invoked proxied method as ExposeInvocationInterceptor is a singleton.
We previously lost the invoked method details.

Original pull request: #280.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Polishing.
Removed superfluous import, throws declaration and public modifiers.
Uses <> operator where applicable.

Original pull request: #280.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Register ExposeRepositoryInvocationInterceptor to isol…
…ate repository method call exposure.

We now ship and register ExposeRepositoryInvocationInterceptor to expose proxy method invocations without interfering with ExposeInvocationInterceptor.
ExposeRepositoryInvocationInterceptor is a copy of ExposeInvocationInterceptor that holds its own instance of the invoked method and that is isolated so no other component can affect exposure of the invoked method.

Interceptors in the invocation chain can invoke methods on proxied objects (e.g. proxied TransactionManager) which override the invoked proxied method as ExposeInvocationInterceptor is a singleton.
We previously lost the invoked method details.

Original pull request: #280.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Polishing.
Removed superfluous import, throws declaration and public modifiers.
Uses <> operator where applicable.

Original pull request: #280.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Register ExposeRepositoryInvocationInterceptor to isol…
…ate repository method call exposure.

We now ship and register ExposeRepositoryInvocationInterceptor to expose proxy method invocations without interfering with ExposeInvocationInterceptor.
ExposeRepositoryInvocationInterceptor is a copy of ExposeInvocationInterceptor that holds its own instance of the invoked method and that is isolated so no other component can affect exposure of the invoked method.

Interceptors in the invocation chain can invoke methods on proxied objects (e.g. proxied TransactionManager) which override the invoked proxied method as ExposeInvocationInterceptor is a singleton.
We previously lost the invoked method details.

Original pull request: #280.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1368 - Polishing.
Removed superfluous import, throws declaration and public modifiers.
Uses <> operator where applicable.

Original pull request: #280.
@schauder

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Done.

@schauder schauder closed this Jul 2, 2019

@schauder schauder deleted the issue/DATAJPA-1368 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.