Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJPA-1372 - Allow Query by Example matching for joined singular attributes #281

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
3 participants
@mp911de
Copy link
Member

commented Jul 9, 2018

We now support Query by Example matching for singular attributes that are joined through embeddable entities. Previously, we rejected these as the metamodel returns a SingularAttributeJoin whereas we always expect a From to create a join.

cc @christophstrobl


Related ticket: DATAJPA-1372.

mp911de and others added some commits Jul 9, 2018

DATAJPA-1372 - Allow Query by Example matching for joined singular at…
…tributes.

We now support Query by Example matching for singular attributes that are joined through embeddable entities. Previously, we rejected these as the metamodel returns a SingularAttributeJoin whereas we always expect a From to create a join.
DATAJPA-1372 - Polishing.
Use diamond syntax where possible.
DATAJPA-1512 - URL Cleanup.
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* http://maven.apache.org/xsd/maven-4.0.0.xsd with 1 occurrences migrated to:
  https://maven.apache.org/xsd/maven-4.0.0.xsd ([https](https://maven.apache.org/xsd/maven-4.0.0.xsd) result 200).
* http://projects.spring.io/spring-data-jpa with 1 occurrences migrated to:
  https://projects.spring.io/spring-data-jpa ([https](https://projects.spring.io/spring-data-jpa) result 301).

# Ignored
These URLs were intentionally ignored.

* http://maven.apache.org/POM/4.0.0 with 2 occurrences
* http://www.w3.org/2001/XMLSchema-instance with 1 occurrences

Original pull request: #333
DATAJPA-1512 - URL Cleanup.
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://www.apache.org/licenses/ with 1 occurrences migrated to:
  https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
* [ ] http://www.apache.org/licenses/LICENSE-2.0 with 341 occurrences migrated to:
  https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).

Original Pull Request: #366

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1372 - Allow Query by Example matching for joined singular at…
…tributes.

We now support Query by Example matching for singular attributes that are joined through embeddable entities.
Previously, we rejected these as the metamodel returns a SingularAttributeJoin whereas we always expect a From to create a join.

Original pull request: #281.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1372 - Polishing.
Use diamond syntax where possible.

Original pull request: #281.
@schauder

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Merged.

@schauder schauder closed this Jul 2, 2019

@schauder schauder deleted the issue/DATAJPA-1372 branch Jul 2, 2019

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1372 - Allow Query by Example matching for joined singular at…
…tributes.

We now support Query by Example matching for singular attributes that are joined through embeddable entities.
Previously, we rejected these as the metamodel returns a SingularAttributeJoin whereas we always expect a From to create a join.

Original pull request: #281.

schauder added a commit that referenced this pull request Jul 2, 2019

DATAJPA-1372 - Polishing.
Use diamond syntax where possible.

Original pull request: #281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.