Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJPA-1560 - Avoid unnecessary creation of exception when checking if a type is managed. #384

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@schauder
Copy link
Contributor

commented Jun 18, 2019

We check a type is managed before trying to access its ManagedType.

https://jira.spring.io/browse/DATAJPA-1560

@shahamit

This comment has been minimized.

Copy link

commented Jun 20, 2019

When is this fix planned to be merged in master? If it's going to take a few days, can someone share the location (url) from where we can download the '2.2.0.BUILD-SNAPSHOT' jar so that we can validate the cpu issue locally?

@schauder

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

It will take a couple of days.

Snapshots get published here:
https://repo.spring.io/snapshot/

This particular one is here:
https://repo.spring.io/snapshot/org/springframework/data/spring-data-jpa/2.2.0.DATAJPA-1560-SNAPSHOT/

@shahamit

This comment has been minimized.

Copy link

commented Jun 25, 2019

@schauder - I understand that this is not the right place to ask but where can I find the release dates for upcoming spring-data-jpa? I am looking forward for this fix but I cannot upgrade to milestone releases. I could not find a page that shows the dates for 2.2 release?

@schauder

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@shahamit we don't advertise release dates in advance because it just leads to frustration and anger when a date slips.

That said it is probably save to assume that a GA release will ship before the Spring One Platform conference at the beginning of October

@schauder schauder closed this Jun 26, 2019

@schauder schauder reopened this Jul 1, 2019

@schauder

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

This shouldn't have been closed.

schauder added some commits Jun 18, 2019

DATAJPA-1560 - Avoid unnecessary creation of exception when checking …
…if a type is managed.

We check a type is managed before trying to access its `ManagedType`.

@schauder schauder force-pushed the issue/DATAJPA-1560 branch from 78c79b5 to 9eedf56 Jul 1, 2019

mp911de added a commit that referenced this pull request Jul 3, 2019

DATAJPA-1560 - Avoid unnecessary creation of exceptions when checking…
… if a type is managed.

We check a type is managed before trying to access its `ManagedType`.

Original pull request: #384.

mp911de added a commit that referenced this pull request Jul 3, 2019

DATAJPA-1560 - Polishing.
Use JpaMetamodel.isJpaManaged(…) in findVersionAttribute(…) to align with other implementations.

Original pull request: #384.

mp911de added a commit that referenced this pull request Jul 3, 2019

DATAJPA-1560 - Avoid unnecessary creation of exceptions when checking…
… if a type is managed.

We check a type is managed before trying to access its `ManagedType`.

Original pull request: #384.

mp911de added a commit that referenced this pull request Jul 3, 2019

DATAJPA-1560 - Polishing.
Use JpaMetamodel.isJpaManaged(…) in findVersionAttribute(…) to align with other implementations.

Original pull request: #384.
@mp911de

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

That's merged, polished, and backported.

@mp911de mp911de closed this Jul 3, 2019

@mp911de mp911de deleted the issue/DATAJPA-1560 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.