diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..79819fd4 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ + + +- [ ] You have read the [Spring Data contribution guidelines](https://github.com/spring-projects/spring-data-build/blob/master/CONTRIBUTING.adoc). +- [ ] There is a ticket in the bug tracker for the project in our [JIRA](https://jira.spring.io/browse/DATALDAP). +- [ ] You use the code formatters provided [here](https://github.com/spring-projects/spring-data-build/tree/master/etc/ide) and have them applied to your changes. Don’t submit any formatting related changes. +- [ ] You submit test cases (unit or integration tests) that back your changes. +- [ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only). diff --git a/README.md b/README.md index 3f57a3b7..5c8fd146 100644 --- a/README.md +++ b/README.md @@ -109,8 +109,8 @@ public class MyService { Here are some ways for you to get involved in the community: * Get involved with the Spring community on Stackoverflow and help out on the [spring-data-ldap](http://stackoverflow.com/questions/tagged/spring-data-ldap) tag by responding to questions and joining the debate. -* Create [JIRA](https://jira.springframework.org/browse/DATALDAP) tickets for bugs and new features and comment and vote on the ones that you are interested in. +* Create [JIRA](https://jira.spring.io/browse/DATALDAP) tickets for bugs and new features and comment and vote on the ones that you are interested in. * Github is for social coding: if you want to write code, we encourage contributions through pull requests from [forks of this repository](http://help.github.com/forking/). If you want to contribute code this way, please reference a JIRA ticket as well covering the specific issue you are addressing. * Watch for upcoming articles on Spring by [subscribing](http://spring.io/blog) to spring.io. -Before we accept a non-trivial patch or pull request we will need you to sign the [contributor's agreement](https://support.springsource.com/spring_committer_signup). Signing the contributor's agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. Active contributors might be asked to join the core team, and given the ability to merge pull requests. +Before we accept a non-trivial patch or pull request we will need you to [sign the Contributor License Agreement](https://cla.pivotal.io/sign/spring). Signing the contributor’s agreement does not grant anyone commit rights to the main repository, but it does mean that we can accept your contributions, and you will get an author credit if we do. If you forget to do so, you'll be reminded when you submit a pull request. Active contributors might be asked to join the core team, and given the ability to merge pull requests.