Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References are not handled properly in Querydsl integration. [DATAMONGO-972] #1896

Closed
spring-projects-issues opened this issue Jun 28, 2014 · 8 comments
Assignees

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jun 28, 2014

Timo Westkämper opened DATAMONGO-972 and commented

References are not handled properly in the Querydsl integration of Spring Data Mongodb. MongodbSerializer provides too related template methods which should be overridden in SpringDataMongodbSerializer.

The Querydsl Mongodb integration with the Morphia mapping framework shows how it can be done https://github.com/querydsl/querydsl/blob/master/querydsl-mongodb/src/main/java/com/mysema/query/mongodb/morphia/MorphiaSerializer.java


Issue Links:

  • DATAMONGO-984 Re-enable test case ignored after Querydsl upgrade

Referenced from: pull request #203

Backported to: 1.5.2 (Dijkstra SR2)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Christoph Strobl commented

Thank you Timo Westkämper for pointing to this. Though it seems that isReference is not called in 3.4.0 and would require an update to 3.4.1, which showed some glitches (see: spring-data-build#90)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Oliver Drotbohm commented

According to the Querydsl issue tracker, 3.4.2 is scheduled for July, 31st which is both after our schedule M1 for Evans and Codd SR2. We could of course add the fixes to the code base but ignore the test cases for now which seems a bit suboptimal. On the other hand, I'd love to get this fix out ASAP.

Timo Westkämper If there's any chance you can do the 3.4.2 release earlier, please let me know

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Oliver Drotbohm commented

I've applied the pull request to the master and bugfix branches. Ignore the test case for now. I'll close this as resolved and open a ticket to remove the @Ignore once we upgrade to 3.4.2

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Timo Westkämper commented

This feature has already been available in Querydsl 3.3.0 https://github.com/querydsl/querydsl/blob/QUERYDSL_3_3_0/querydsl-mongodb/src/main/java/com/mysema/query/mongodb/morphia/MorphiaSerializer.java

An earlier release date for 3.4.2 should not be necessary

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Oliver Drotbohm commented

The test is failing when run against a Querydsl version < 3.4.1. It works on 3.4.1, though. The relevant methods don't seem to be called in versions prior to 3.4.1

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Timo Westkämper commented

Sorry, you are right. There was a related fix in 3.4.1 querydsl/querydsl#803.

What would be a suitable release date for you?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Oliver Drotbohm commented

The milestone is scheduled for tomorrow but I'd understand that that's a bit of a rush. I have merged the fix already, so it's just the test case that needs to be reactivated. If you can sneak it in earlier than end of June, fine. If not, then that's it, no big deal :)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Timo Westkämper commented

Ok, I will try something earlier, I will be working again beginning from 21.7. I will try to make the release that week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants