Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of $max and $min update operations [DATAMONGO-1404] #2317

Closed
spring-projects-issues opened this issue Mar 30, 2016 · 9 comments
Closed
Assignees
Labels
in: core type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik opened DATAMONGO-1404 and commented

For some reason $min and $max update operation are not yet supported


Affects: 1.8.2 (Gosling SR2), 1.9 RC1 (Hopper), 1.8.4 (Gosling SR4)

Issue Links:

  • DATAMONGO-1412 Document mapping rules for Java types to MongoDB representation

  • DATAMONGO-941 Add support for $min to Update
    ("supersedes")

  • DATAMONGO-942 Add support for $max to Update
    ("supersedes")

Referenced from: pull request #353

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

My CLA number is 169820160330091912

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

Mark suggested me to write some tests. Newby to your project codebase, please give me some time...

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Mark Paluch commented

Thanks for the CLA. No worries. If it's too much of a hassle for you, I can take it from here

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

Colud you please show me how to run tests? mvn test fails

Results :

Failed tests:   shouldRetrieveDateTimeFragementsCorrectly(org.springframework.data.mongodb.core.aggregation.AggregationTests): (..)
  allowsNestedFieldReferencesAsGroupIdsInGroupExpressions(org.springframework.data.mongodb.core.aggregation.AggregationTests): (..)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

Tests added

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Mark Paluch commented

We usually build it that way mvn clean install but you should be able to run tests from your IDE. An external MongoDB (3.0+) instance on port 27017 needs to run

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

Mark, do the tests cover corner cases? Should I add something else?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Alexey Plotnik commented

Ok, see that. Great, thanks

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Mark Paluch commented

All good, thanks for the great contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants