Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency cycles [DATAMONGO-1721] #2629

Closed
spring-projects-issues opened this issue Jun 21, 2017 · 3 comments
Closed

Fix dependency cycles [DATAMONGO-1721] #2629

spring-projects-issues opened this issue Jun 21, 2017 · 3 comments
Assignees
Labels
type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jun 21, 2017

Jens Schauder opened DATAMONGO-1721 and commented

  • No cycles between packages
  • Nothing but config should depend on "repository"

Referenced from: pull request #470

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 22, 2017

Jens Schauder commented

The core package contains more classes that sound like the belong to core.index, but I left them where they are for now and moved only those necessary to fix the cycles.

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 22, 2017

Jens Schauder commented

Not sure if I fixed all the problems you saw. This fixes the internal dependency cycles. If there are other constraints violated that I don't know about yet, let me know

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jun 22, 2017

Jens Schauder commented

Travis fails. Have to look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants