Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for $sampleRate aggregation operator #3726

Closed
christophstrobl opened this issue Jul 14, 2021 · 5 comments
Closed

Add support for $sampleRate aggregation operator #3726

christophstrobl opened this issue Jul 14, 2021 · 5 comments
Labels
in: aggregation-framework Aggregation framework support type: enhancement A general enhancement
Milestone
3.3 M3 (2021.1.0)

Comments

@christophstrobl
Copy link
Member

Available since MongoDB 4.4.2.
@christophstrobl christophstrobl added type: enhancement A general enhancement in: aggregation-framework Aggregation framework support labels Jul 14, 2021
JamesMcNee added a commit to JamesMcNee/spring-data-mongodb that referenced this issue Aug 7, 2021
@JamesMcNee
spring-projectsGH-3726: Add support for $sampleRate aggregation opera…
4621303 
…tion

Closes spring-projects#3726
@JamesMcNee JamesMcNee mentioned this issue Aug 7, 2021
Closed
4 tasks
@JamesMcNee
Copy link
Contributor

Hi @christophstrobl I had a crack at this (see PR), hope that is ok? First time contributing to Spring but I think I have followed all of the contributing guidelines!

JamesMcNee added a commit to JamesMcNee/spring-data-mongodb that referenced this issue Aug 7, 2021
@JamesMcNee
spring-projectsGH-3726: Add support for $sampleRate aggregation opera…
bab0c9e 
…tion

Closes spring-projects#3726
@christophstrobl
Copy link
Member Author

@JamesMcNee thanks for the PR! Please pardon delayed review/responses during the summer/holiday season. Thanks for your understanding! We'll have a look asap.

@JamesMcNee
Copy link
Contributor

@christophstrobl Absolutely no worries! Enjoy the holidays! 🌴

@JamesMcNee
Copy link
Contributor

Realised that I had actually implemented this incorrectly. Will raise as a new PR when complete, apologies.

JamesMcNee added a commit to JamesMcNee/spring-data-mongodb that referenced this issue Aug 7, 2021
@JamesMcNee
spring-projectsGH-3726: Add support for $sampleRate match expression.
caff79f 
Closes spring-projects#3726
@JamesMcNee JamesMcNee mentioned this issue Aug 7, 2021
Closed
4 tasks
@JamesMcNee
Copy link
Contributor

New PR raised here. Looking forward to any feedback when you have time and are back from the summer holidays 😄

JamesMcNee added a commit to JamesMcNee/spring-data-mongodb that referenced this issue Aug 26, 2021
@JamesMcNee
spring-projectsGH-3726: Add support for $sampleRate.
a40d15c 
Closes spring-projects#3726
JamesMcNee added a commit to JamesMcNee/spring-data-mongodb that referenced this issue Aug 26, 2021
@JamesMcNee
spring-projectsGH-3726: Add support for $sampleRate.
8c0fe2c 
Closes spring-projects#3726
@mp911de mp911de added this to the 3.3 M3 (2021.1.0) milestone Aug 27, 2021
mp911de added a commit that referenced this issue Aug 27, 2021
@mp911de
Polishing.
f662d7c 
Tweak Javadoc. Add since tag, reformat code. Simplify tests. Move documentation bits into the right place.

See #3726.
Original pull request: #3765.
@mp911de mp911de changed the title Add support for $sampleRate aggregation operator. Add support for $sampleRate aggregation operator Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: aggregation-framework Aggregation framework support type: enhancement A general enhancement
Projects
None yet
Milestone
3.3 M3 (2021.1.0)
3 participants
@mp911de @christophstrobl @JamesMcNee