Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAMONGO-1337 - General code quality improvements #336

Closed
wants to merge 1 commit into from
Closed

DATAMONGO-1337 - General code quality improvements #336

wants to merge 1 commit into from

Conversation

civanyp
Copy link
Contributor

@civanyp civanyp commented Nov 26, 2015

This pull request is focused on resolving occurrences of Sonar rule:
squid:S1312 - Loggers should be private static final and should share a naming convention
squid:S1132 - String literals should be placed on the left side when checking for equality
squid:S1155 - Collection.isEmpty() should be used to test for emptiness of collections

You can find more information about the issue here:
dev.eclipse.org/sonar/rules/show/squid:S1312
dev.eclipse.org/sonar/rules/show/squid:S1132
dev.eclipse.org/sonar/rules/show/squid:S1155

Please let me know if you have any questions.

Christian

odrotbohm pushed a commit that referenced this pull request Nov 26, 2015
A round of code polish regarding the PMD and Squid rules referred to in the ticket.

Original pull request: #336.
odrotbohm pushed a commit that referenced this pull request Nov 26, 2015
A round of code polish regarding the PMD and Squid rules referred to in the ticket.

Original pull request: #336.
odrotbohm pushed a commit that referenced this pull request Nov 26, 2015
A round of code polish regarding the PMD and Squid rules referred to in the ticket.

Original pull request: #336.
@odrotbohm
Copy link
Member

That's been merged, thanks!

@odrotbohm odrotbohm closed this Nov 26, 2015
odrotbohm added a commit that referenced this pull request Nov 26, 2015
The logger instance in AbstractMonitor is supposed to pick up the type of the actual implementation class and thus cannot be static.

Related pull request: #336.
odrotbohm added a commit that referenced this pull request Nov 26, 2015
The logger instance in AbstractMonitor is supposed to pick up the type of the actual implementation class and thus cannot be static.

Related pull request: #336.
odrotbohm added a commit that referenced this pull request Nov 26, 2015
The logger instance in AbstractMonitor is supposed to pick up the type of the actual implementation class and thus cannot be static.

Related pull request: #336.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants