OGM unable to apply a collection of values from database into a Set [DATAGRAPH-644]

[spring-projects-issues]

Greg Guydo opened DATAGRAPH-644 and commented

Given a class has a Set instead of a List of values, these cannot be appied back onto the object upon querying, with error "org.neo4j.ogm.entityaccess.EntityAccessException: Failed to invoke method 'setXxxx'. Expected argument type: interface java.util.Set actual argument type class java.util.ArrayList"

It seems the fix would be to add at line 81 in EntityAccess.java the following:

if (Set.class.isAssignableFrom(parameterType)) {
    return new HashSet<>(union(collection, hydrated));
}

---

Affects: 4.0 M1

[spring-projects-issues]

Luanne Misquitta commented

Could you please share the class that contains the Set? Or a test case? Thanks!

[spring-projects-issues]

Greg Guydo commented

Luanne, In my use case I have a class that looks like this:

@RelationshipEntity("type" = "AUTHORIZED_UNDER")
public class Authorization extends BaseRelationship<Account, Group> {

  @StartNode
  private Account account;

  @EndNode
  private Group group;

  @GraphId 
  private Long id;

  private Date createdDate;
   
  private Set<String> roles;

  // ... getters and setters...

}

so the graph has a property that looks like this:

roles: ["USER", "ADMINSTRATOR"]

which can't be applied back to the OGM

[spring-projects-issues]

Luanne Misquitta commented

Added tests. The fix proposed by Greg works well.

OGM Snapshot #35