Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AspectJ 1.7.0 / AJDT 2.20 / Eclipse 4.2 Juno [DATAGRAPH-280] #844

Closed
spring-projects-issues opened this issue Aug 6, 2012 · 5 comments
Labels
type: bug
Milestone

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Aug 6, 2012

Johannes Mockenhaupt opened DATAGRAPH-280 and commented


Affects: 2.0.1

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Aug 6, 2012

Johannes Mockenhaupt commented

(Sorry for screwing up the description).

When compiling SDN against AspectJ 1.7.0 the errors below occur. It would be nice if SDN would support AspectJ 1.7.0, as Eclipse 4.2 uses AJDT 2.2.0, which in turn uses AspectJ 1.7.0. Hence the errors below, reported by maven, are flagged as errors by Eclipse as well.

[INFO] --- aspectj-maven-plugin:1.2:test-compile (test-compile) @ spring-data-neo4j-aspects ---
[ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String;)
[ERROR] The type org.springframework.data.neo4j.aspects.Group must implement the inherited abstract method org.springframework.data.neo4j.aspects.core.NodeBacked.relateTo(Lorg/springframework/data/neo4j/aspects/core/NodeBacked;Ljava/lang/Class;Ljava/lang/String;Z)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Aug 27, 2012

Andy Clement commented

This problem is raised against AspectJ as https://bugs.eclipse.org/bugs/show_bug.cgi?id=386888 - that bug has just been fixed and fixes are available in 1.7.1 build snapshots (1.7.1.BUILD-SNAPSHOT from the maven spring snapshots repo). I am currently trying to get it into AJDT dev builds but my git push is timing out (damn thing!) - it should be in AJDT in a couple of days

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 6, 2012

Andy Clement commented

This should now be addressed in AspectJ 1.7.1 (bug 386888 is fixed) which is packaged inside AJDT 2.2.1 dev builds. Those dev builds are available at this update site (for eclipse 4.2): http://download.eclipse.org/tools/ajdt/42/dev/update

I just tried out the hello-worlds sample and it failed with the default AJDT (with the errors above), I then upgraded my AJDT to the dev build and it then compiled clean.

Hopefully STS 3.1 will include AJDT 2.2.1 (AspectJ 1.7.1)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 19, 2012

Johannes Mockenhaupt commented

Thanks Andy, it's fixed for me too. I made a pull request that updates the docs accordingly (#83)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Sep 20, 2012

Michael Hunger commented

Thanks Andy & Johannes.

Merged the PR.

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

1 participant