Add support for geo commands. [DATAREDIS-438]

[spring-projects-issues]

Christoph Strobl opened DATAREDIS-438 and commented

Add support for:

GEOADD key longitude latitude member [longitude latitude member ...]

GEOHASH key member [member ...]

GEOPOS key member [member ...]

GEODIST key member1 member2 [unit]

GEORADIUS key longitude latitude radius m|km|ft|mi [WITHCOORD] [WITHDIST] [WITHHASH] [COUNT count]

GEORADIUSBYMEMBER key member radius m|km|ft|mi [WITHCOORD] [WITHDIST] [WITHHASH] [COUNT count]

---

Issue Links:

• DATAREDIS-437 Upgrade to Jedis 2.8.0
  ("depends on")

Referenced from: pull request #187, and commits a3c4fc6, 6e1cb94, a222fb3, f732b5f, b0e20d3, 49190fa, d423222, 74b0aa5

2 votes, 3 watchers

[spring-projects-issues]

Ninad Divadkar commented

I'd like to help with this one, if thats OK. Will these commands go in a GeoOperations interface?

[spring-projects-issues]

Ninad Divadkar commented

PR - #186

[spring-projects-issues]

Mark Paluch commented

Hi Ninad Divadkar,

thanks for the PR. We would shift Redis Geo to Hopper+1. GeoOperations is the right place for the operations. I also think having a remove method that maps to ZREM would be good as there is no explicit GEOREM command alias yet. The missing GEOREM is a constant source of confusion to users.

Redis Geo introduces with GEORADIUS and GEORADIUSBYMEMBER an API with conditional response structures that change on the input args (WITHDIST, WITHHASH, STORE, …). The most effort is designing an API that is good to use and that uses the Geo support from Data Commons so we are not totally different with e.g. Spring Data MongoDB

[spring-projects-issues]

Ninad Divadkar commented

Sounds good. I'll update the PR as I put in more commands. I'll also look into the Geo support that Data Commons has

[spring-projects-issues]

Ninad Divadkar commented

@Mark, when will the travis-ci build move from redis-3.0.7 to redis-3.2.0? Will this have to wait for the release version of 3.2.0 ?
BTW, new PR - #187

[spring-projects-issues]

Ninad Divadkar commented

CLA - 169220160326121428, Name - Ninad Divadkar

[spring-projects-issues]

Ninad Divadkar commented

Added support for Geo commands after consulting with Mark Pulach and Christoph Strobl