Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for geo commands. [DATAREDIS-438] #1015

Closed
spring-projects-issues opened this issue Dec 7, 2015 · 7 comments
Closed

Add support for geo commands. [DATAREDIS-438] #1015

spring-projects-issues opened this issue Dec 7, 2015 · 7 comments
Assignees
Labels
in: core in: jedis in: lettuce type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Dec 7, 2015

Christoph Strobl opened DATAREDIS-438 and commented

Add support for:

GEOADD key longitude latitude member [longitude latitude member ...]

GEOHASH key member [member ...]

GEOPOS key member [member ...]

GEODIST key member1 member2 [unit]

GEORADIUS key longitude latitude radius m|km|ft|mi [WITHCOORD] [WITHDIST] [WITHHASH] [COUNT count]

GEORADIUSBYMEMBER key member radius m|km|ft|mi [WITHCOORD] [WITHDIST] [WITHHASH] [COUNT count]

Issue Links:

Referenced from: pull request #187, and commits a3c4fc6, 6e1cb94, a222fb3, f732b5f, b0e20d3, 49190fa, d423222, 74b0aa5

2 votes, 3 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 27, 2016

Ninad Divadkar commented

I'd like to help with this one, if thats OK. Will these commands go in a GeoOperations interface?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 28, 2016

Ninad Divadkar commented

PR - #186

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 29, 2016

Mark Paluch commented

Hi Ninad Divadkar,

thanks for the PR. We would shift Redis Geo to Hopper+1. GeoOperations is the right place for the operations. I also think having a remove method that maps to ZREM would be good as there is no explicit GEOREM command alias yet. The missing GEOREM is a constant source of confusion to users.

Redis Geo introduces with GEORADIUS and GEORADIUSBYMEMBER an API with conditional response structures that change on the input args (WITHDIST, WITHHASH, STORE, …). The most effort is designing an API that is good to use and that uses the Geo support from Data Commons so we are not totally different with e.g. Spring Data MongoDB

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 30, 2016

Ninad Divadkar commented

Sounds good. I'll update the PR as I put in more commands. I'll also look into the Geo support that Data Commons has

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 3, 2016

Ninad Divadkar commented

@Mark, when will the travis-ci build move from redis-3.0.7 to redis-3.2.0? Will this have to wait for the release version of 3.2.0 ?
BTW, new PR - #187

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 11, 2016

Ninad Divadkar commented

CLA - 169220160326121428, Name - Ninad Divadkar

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 10, 2016

Ninad Divadkar commented

Added support for Geo commands after consulting with Mark Pulach and Christoph Strobl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core in: jedis in: lettuce type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants