Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JedisClusterStringCommands.set(…) contains redundant null checks [DATAREDIS-706] #1280

Closed
spring-projects-issues opened this issue Sep 28, 2017 · 0 comments
Closed

JedisClusterStringCommands.set(…) contains redundant null checks [DATAREDIS-706] #1280

spring-projects-issues opened this issue Sep 28, 2017 · 0 comments
Assignees
@mp911de
Labels
in: jedis type: enhancement
Milestone
2.1 M1 (Lovelace)

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Sep 28, 2017

xiaohu-zhang opened DATAREDIS-706 and commented

org.springframework.data.redis.connection.jedis.JedisClusterStringCommands.set(byte[], byte[], Expiration, SetOption)
both have the

     Assert.notNull(expiration, "Expiration must not be null!");
Assert.notNull(option, "Option must not be null!");

and

if (expiration == null
if (option == null

that is redundance in the code

Affects: 2.0.1 (Kay SR1)

Referenced from: pull request #278

Backported to: 2.0.2 (Kay SR2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
in: jedis type: enhancement
Projects
None yet
Milestone
2.1 M1 (Lovelace)
Development

No branches or pull requests
2 participants
@mp911de @spring-projects-issues