Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary cache configuration map creation in RedisCacheManagerBuilder [DATAREDIS-728] #1303

Closed
spring-projects-issues opened this issue Nov 9, 2017 · 0 comments
Assignees
Labels
in: cache type: enhancement

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Nov 9, 2017

Kezhu Wang opened DATAREDIS-728 and commented

RedisCacheManagerBuilder.withInitialCacheConfiguration appends new cache configurations by doing:

  1. Create a new map initialized with existing cache configuration.
  2. Put all new cache configurations to that newly created map.
  3. Assign the newly created map to field initialCaches.

While just Map.putAll can accomplish this


Affects: 2.0.1 (Kay SR1)

Referenced from: pull request #293, and commits 1a6f51a, c454f42, ecb19f4, 1504c76

Backported to: 2.0.2 (Kay SR2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: cache type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants