Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share native Lettuce Cluster connection across LettuceClusterConnection [DATAREDIS-731] #1308

Closed
spring-projects-issues opened this issue Nov 15, 2017 · 5 comments

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Ángel Luis López Monterroso opened DATAREDIS-731 and commented

Hello!
Into Stackoverflow: https://stackoverflow.com/questions/47300198/possible-performance-issue-with-cluster-spring-data-redis-lettuce
I left a message explaining a possible performance issue, this have 3 purposes.

  • Detect a possible performance issue
  • Know if we are using springdata redis+lettuce using good practices
  • Know if using jedis driver will not have this performance impact in case of exists

Affects: 1.8.3 (Ingalls SR3)

Reference URL: https://stackoverflow.com/questions/47300198/possible-performance-issue-with-cluster-spring-data-redis-lettuce

Referenced from: pull request #297

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Mark Paluch commented

I'm not sure I follow. What is your actual question?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Ángel Luis López Monterroso commented

Is a real performance issue, or it's a bad usage of spring data redis + lettuce?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Mark Paluch commented

So your actual concern is

Its mandatory open a new connection for every operation?

Spring Data Redis does not use a shared cluster connection but opens a new connection (in the last consequence) each time you call a command via RedisTemplate. That's quite inefficient and I think we should be able to improve here. We already share a single JedisCluster across multiple JedisClusterConnection instances and we could apply the same pattern for Lettuce to prevent connect and disconnects each time a command is executed

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Ángel Luis López Monterroso commented

Ok, thanks!!
Need I to open you a improvement issue?
MEanwhile we are going to test the jedis driver.
Regards

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 15, 2017

Mark Paluch commented

Let's take this ticket to introduce a shared connection for Redis Cluster using Lettuce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.