Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LettuceSslClientConfigurationBuilder methods are package-protected [DATAREDIS-755] #1336

Closed
spring-projects-issues opened this issue Jan 16, 2018 · 3 comments
Assignees
Labels
in: lettuce type: bug

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Jan 16, 2018

Matthew Barr opened DATAREDIS-755 and commented

When using the LettuceConnectionFactory in versions previous to 2.0, you could use the .useSsl() method to use ssl for the connection. With 2.0, that is now deprecated, and documented to use LettuceClientConfiguration instead.

Issue is when using the code from the documentation here, it doesn't compile. The LettuceClientConfiguration.Builder.useSsl() method returns a LettuceSslClientConfigurationBuilder that has no public methods, and isn't accepted as a parameter in LettuceConnectionFactory.

Apologies if I'm doing something wrong, or missed documentation on how to properly configure Lettuce with ssl.


Affects: 2.0.2 (Kay SR2)

Reference URL: https://stackoverflow.com/questions/48288993/spring-session-2-0-redis-lettuce-configuration

Backported to: 2.0.3 (Kay SR3)

1 votes, 3 watchers

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Jan 17, 2018

Mark Paluch commented

Good catch, that's a bug

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Jan 17, 2018

Mark Paluch commented

That's fixed now. I left a comment on your SO post how to work around until the fix is shipped

@spring-projects-issues
Copy link
Author

spring-projects-issues commented Jan 17, 2018

Matthew Barr commented

That's some quick work sir. Thanks so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: lettuce type: bug
Projects
None yet
Development

No branches or pull requests

2 participants