RedisCache should not expire known keys in case ttl of element is not set. [DATAREDIS-402]

[spring-projects-issues]

Christoph Strobl opened DATAREDIS-402 and commented

We need to check if an element is eternal when setting TTL for the set of known keys. Otherwise we'd expire the_ZSET_ immediately which breaks Cache.clear since we do not know about the eternal key any more.

    protected void maintainKnownKeys(RedisCacheElement element, RedisConnection connection) {

			if (!element.hasKeyPrefix()) {
				connection.zAdd(cacheMetadata.getSetOfKnownKeysKey(), 0, element.getKeyBytes());
				if (!element.isEternal()) {
					connection.expire(cacheMetadata.getSetOfKnownKeysKey(), element.getTimeToLive());
				}
			}
		}

---

Affects: 1.5 GA (Fowler)

Referenced from: pull request #141

Backported to: 1.5.1 (Fowler SR1)

[spring-projects-issues]

Thomas Darimont commented

LGTM, cp'ed into master and 1.5.x