Skip to content

Fix bug issues/2651 ,wrong assignment in DefaultRedisSerializationContextBuilder.string #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix bug issues/2651 ,wrong assignment in DefaultRedisSerializationContextBuilder.string #2652

wants to merge 2 commits into from

Conversation

@imzhoukunqiang
Copy link
Contributor

@imzhoukunqiang imzhoukunqiang commented Jul 26, 2023 •
edited
Loading

DefaultRedisSerializationContextBuilder.string() should assign param to stringTuple instead of hashValueTuple
see #2651

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@imzhoukunqiang imzhoukunqiang changed the title Fix bug issues/2651 Fix bug issues/2651 ,wrong assignment in DefaultRedisSerializationContextBuilder.string Jul 26, 2023
@imzhoukunqiang imzhoukunqiang marked this pull request as ready for review July 26, 2023 16:12
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 26, 2023
@jxblum jxblum mentioned this pull request Jul 27, 2023
Closed
@jxblum jxblum self-assigned this Jul 27, 2023
@jxblum jxblum added this to the 2.7.15 (2021.2.15) milestone Jul 27, 2023
@jxblum jxblum added type: bug A general bug in: core Issues in core support and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 27, 2023
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@imzhoukunqiang @jxblum
DefaultRedisSerializationContextBuilder.string() should assign 'tuple…
ddeccf0 
…' to 'stringTuple'.

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@jxblum
Polish for RedisSerializationContext.
544b176 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@imzhoukunqiang @jxblum
DefaultRedisSerializationContextBuilder.string() should assign 'tuple…
9e33a1b 
…' to 'stringTuple'.

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@jxblum
Polish for RedisSerializationContext.
eb2e9de 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@imzhoukunqiang @jxblum
Assign 'tuple' to 'stringTuple' in DefaultRedisSerializationContextBu…
a3e35a3 
…ilder.string().

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@jxblum
Polish for RedisSerializationContext.
59a7266 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@imzhoukunqiang @jxblum
Assign 'tuple' to 'stringTuple' in DefaultRedisSerializationContextBu…
31bdc36 
…ilder.string().

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@jxblum
Polish for RedisSerializationContext.
6769b4b 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@imzhoukunqiang @jxblum
Assign 'tuple' to 'stringTuple' in DefaultRedisSerializationContextBu…
675c617 
…ilder.string().

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 27, 2023
@jxblum
Polish for RedisSerializationContext.
42f2184 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum pushed a commit to jxblum/spring-data-redis that referenced this pull request Jul 28, 2023
@imzhoukunqiang @jxblum
Assign 'tuple' to 'stringTuple' in DefaultRedisSerializationContextBu…
ded40f5 
…ilder.string().

Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 28, 2023
@jxblum
Polish for RedisSerializationContext.
563cccc 
Closes spring-projects#2651
Original pull request: spring-projects#2652
jxblum added a commit to jxblum/spring-data-redis that referenced this pull request Jul 28, 2023
@jxblum
Polish for RedisSerializationContext.
f6663f7 
Closes spring-projects#2651
Original pull request: spring-projects#2652
@jxblum jxblum closed this Jul 28, 2023
@jxblum
Copy link
Contributor

jxblum commented Jul 28, 2023

This has been reviewed, polished and merged back to 2.7.x (onward). Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jxblum jxblum

Labels

in: core Issues in core support type: bug A general bug

Projects

None yet

Milestone

2.7.15 (2021.2.15)

Development

Successfully merging this pull request may close these issues.

3 participants

@imzhoukunqiang @jxblum @spring-projects-issues