Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdtMessageListenerContainer doesn't support durable named consumer. [DATAJDBC-42] #298

Closed
spring-projects-issues opened this issue Feb 21, 2013 · 1 comment
Assignees
Labels
in: core type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Feb 21, 2013

Lukasz Rzeszotarski opened DATAJDBC-42 and commented

Current implementation of
org.springframework.data.jdbc.jms.listener.oracle.AdtMessageListenerContainer
doesn't support durableSubscribers. Even if you try define so in spring context definition by using

<jms:listener-container connection-factory="connectionFactory"
	client-id="LUKAS"
	cache="test"
	container-class="org.springframework.data.jdbc.jms.listener.oracle.AdtMessageListenerContainer"
	destination-type="durableTopic">
	<jms:listener destination="TEST_QUEUE" 
		ref="messageDelegate" method="handleMessage" subscription="LUKAS" />
</jms:listener-container>	

I think in AdtMessageListenerContainer#createConsumer should be sth like:

if (durable) {
return ((AQjmsSession) session).createDurableSubscriber(topic, consumerName, null, false, new OraDataFactory());
} else {
return ((AQjmsSession) session).createConsumer(destination, null, new OraDataFactory(), null, false);
}

Another problem is that without extending AdtMessageListenerContainer you cannot through <jms:listener-container /> definition define consumer name. Because "client-id" and "subscription" parameters are not mapped to consumer name which is what I see randomly generated by oracle aqapi. In some case it would be nice to have possiblity to set up name of the durable consumer when you are using ADT payloads.


Affects: Ext 1.0 RELEASE

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 27, 2017

Thomas Risberg commented

Closing very old issue, please re-open as GitHub issue (https://github.com/spring-projects/spring-data-jdbc-ext) if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: bug
Projects
None yet
Development

No branches or pull requests

2 participants