Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change attribute name to rowMapper from rowMapperClass on @Query [DATAJDBC-203] #430

Closed
spring-projects-issues opened this issue Apr 13, 2018 · 2 comments
Assignees
Labels
in: repository status: declined type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Apr 13, 2018

Kazuki Shimizu opened DATAJDBC-203 and commented

I feel the "Class" suffix is redundant.
I prefer the rowMapper in this case. WDYT?


Affects: 1.0 M2 (Lovelace)

Reference URL: https://jira.spring.io/browse/DATAJDBC-165

Referenced from: pull request #63

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 16, 2018

Jens Schauder commented

I used the class suffix because I expect that there might eventually be a variant taking a bean name instead.

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Apr 21, 2018

Kazuki Shimizu commented

OK. I agree with your opinion. I've looked other annotation provided by Spring Data, many annotations seem to created by same rule

@spring-projects-issues spring-projects-issues added status: declined in: repository type: enhancement labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository status: declined type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants