Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation for sql type [DATAJDBC-239] #464

Closed
spring-projects-issues opened this issue Jul 20, 2018 · 5 comments
Closed

Annotation for sql type [DATAJDBC-239] #464

spring-projects-issues opened this issue Jul 20, 2018 · 5 comments
Assignees
Labels
status: declined type: enhancement

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jul 20, 2018

Jens Schauder opened DATAJDBC-239 and commented

We need a way to specify the java.sql.Types value to be used for binding parameters.

This applies to

  • columns/properties
  • converters
  • method parameters

The idea is to have a single annotation that can be used in all these places


Issue Links:

3 votes, 5 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 7, 2018

Jens Schauder commented

When this is implemented for converters it should solve DATAJDBC-148

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 11, 2019

Jens Schauder commented

The converters part is currently getting implemented by DATAJDBC-327

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Aug 27, 2019

Johannes Edmeier commented

Without this feature it's also currently not possible to use custom value types as Ids for aggregates with nested entities.
Reason: org.springframework.data.jdbc.core.convert.DefaultDataAccessStrategy.findAllByPath() uses the id as query parameters, which currently don't get converted

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Aug 28, 2019

Jens Schauder commented

Johannes Edmeier is this still the case for the master branch (1.1 milestone) if so please create a separate issue for this

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented May 15, 2020

Jens Schauder commented

It currently doesn't look like this is needed

@spring-projects-issues spring-projects-issues added status: declined type: enhancement labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants