Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally register RelationalMappingContext and RelationalConverter in JdbcRepositoryConfigExtension [DATAJDBC-244] #468

Open
spring-projects-issues opened this issue Jul 26, 2018 · 1 comment
Assignees
Labels
in: repository type: task

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Jul 26, 2018

Mark Paluch opened DATAJDBC-244 and commented

We should conditionally (if not already registered) register RelationalMappingContext and RelationalConverter (pre-initialized with JdbcCustomConversions) in the configuration extension to provide default beans and to not force users to import JdbcConfiguration


Issue Links:

  • DATAJDBC-243 Using @EnableJdbcRepositories and extending JdbcConfiguration causes duplicate bean registrations
    ("depends on")

Referenced from: commits d301169

1 votes, 3 watchers

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Jul 26, 2018

Jens Schauder commented

After taking a look: there doesn't seem to be much of a requirement to import/extend JdbcCustomConversion. The only case seems to be if the one wants to use a custom DataAccessStrategy, like when using MyBatis. Because then you actually need access to conversions and context

@spring-projects-issues spring-projects-issues added in: repository type: task labels Dec 31, 2020
mp911de added a commit that referenced this issue Feb 21, 2022
We now map results of exists queries to a boolean flag to ensure proper decoding. Previously, results were attempted to be mapped onto a primitive type which failed as there's no converter registered for Row to Boolean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository type: task
Projects
None yet
Development

No branches or pull requests

2 participants