Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested Sort properties [DATAREST-910] #1166

Closed
spring-projects-issues opened this issue Sep 27, 2016 · 1 comment
Closed

Support nested Sort properties [DATAREST-910] #1166

spring-projects-issues opened this issue Sep 27, 2016 · 1 comment

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 27, 2016

Mark Paluch opened DATAREST-910 and commented

Allow usage of nested Sort properties applying Jackson-aware field to property mapping. Currently, nested sort properties are filtered because sort mapping considers only top-level properties.

Jackson-field to property mapping should be relaxed and fall back to non-translated properties if the domain type can not be resolved


Issue Links:

  • DATACMNS-918 Provide interfaces for Pageable and Sort method argument resolvers
    ("depends on")
  • DATAREST-912 DomainObjectReader removes unwrapped properties

Referenced from: pull request #232

Backported to: 2.6 RC1 (Ingalls)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Nov 25, 2016

Michael S commented

Hi guys, are there any updates on this ticket and PR? I'm asking because we're updating our apps to spring-cloud Camden release train and spring boot 1.4 - and nested Sort properties used to work prior to SDR 2.4.4. I am not sure whether sorting by nested properties was an unintentional feature, but our app was relying on it (and on the error message on unknown sort property that gets silently ignored now). Anyway, this commit for 2.4.5 removed this feature. We can get around it by extending RepositoryRestMvcConfiguration and overriding defaultMethodArgumentResolvers using the pre-2.4.5. resolvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants