Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort mapping does not consider Jackson customizations in field names [DATAREST-883] #1253

Closed
spring-projects-issues opened this issue Sep 1, 2016 · 2 comments
Assignees
Labels
type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 1, 2016

Oliver Drotbohm opened DATAREST-883 and commented

Currently the Sort instance derived from an HTTP request gets the fields forwarded to the repository without any Jackson customizations (e.g. field name customizations) applied.

That means that although you might have customized the field name in the representation, the request parameter for the sort would still expose the underlying property names


Affects: 2.4.4 (Gosling SR4), 2.5.2 (Hopper SR2), 2.6 M1 (Ingalls)

Issue Links:

  • DATAREST-909 Revert Jackson-aware Sort and Pageable translation in Hopper and Gosling release trains

Referenced from: pull request #222

Backported to: 2.5.3 (Hopper SR3), 2.4.5 (Gosling SR5)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 29, 2017

Andrii Neverov commented

It looks like the fix has been reverted and the issue is still present with Spring Boot 1.5.8.RELEASE. Can this request be reopened?

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Oct 29, 2017

Oliver Drotbohm commented

No, as it has been marked fixed against released versions and shows up in those version's changelog. The original fix has been reversed in favor of a better fix (see the commits linked to from the right bar). If you still see erroneous behaviour in current Ingalls, please open a new ticket describing the exact problem you're seeing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants