Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Patch for arrays is broken [DATAREST-886] #1256

Closed
spring-projects-issues opened this issue Sep 6, 2016 · 0 comments
Closed

JSON Patch for arrays is broken [DATAREST-886] #1256

spring-projects-issues opened this issue Sep 6, 2016 · 0 comments
Assignees
Labels
type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 6, 2016

Oliver Trosien opened DATAREST-886 and commented

There is a TODO in line 126 of org.springframework.data.rest.webmvc.json.patch.JsonPatchPatchConverter pointing out that patching array values is not supported yet.

As a result when you try to patch a collection-based property, Spring Data REST will instead set the value to null.

Take, for example, this request:

[{ "op": "replace", "path": "/hello", "value": ["world","galaxy"] }]

I would expect either...

  • a proper implementation (preferred ;-) )
  • nothing, but a warning on the server side that this operation was ignored
  • an unsupported operation exception indicating the client that his request was rejected

Affects: 2.5.2 (Hopper SR2)

Referenced from: pull request #226

Backported to: 2.5.3 (Hopper SR3)

1 votes, 2 watchers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants