Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Patch silently nullifies property values [DATAREST-889] #1259

Closed
spring-projects-issues opened this issue Sep 7, 2016 · 0 comments
Closed
Assignees
Labels
type: bug

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Sep 7, 2016

Oliver Trosien opened DATAREST-889 and commented

The current JSON patch implementation internally catches exceptions (JsonLateObjectEvaluator line 41) and misses certain cases in if-else-statements (JsonPatchPatchConverter line 127), resulting in SDR setting the property value to null. This is quite bad, as already noticed in DATAREST-886. Instead some exception, like the PatchException should be thrown to avoid applying wrong changes.


Affects: 2.5.2 (Hopper SR2)

Referenced from: pull request #227

Backported to: 2.5.3 (Hopper SR3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug
Projects
None yet
Development

No branches or pull requests

2 participants