MappingAwarePageableArgumentResolver accidentally drops default Pageable returned from delegate PageableHandlerMethodArgumentResolver [DATAREST-906]

[spring-projects-issues]

Michael Igler opened DATAREST-906 and commented

After upgrading to spring-boot 1.4.1 which includes Hopper-SR3 I get a NPE in the following code section when Pageable is not set explicitly:

public Page<Translation> findTranslationsBy(String isoCode, Pageable pageable) {
log.info("" + pageable.getPageSize());
....
}

Setting HOPPER-SR2 in pom.xml fixes the problem as a default page-size is taken into account.

---

Affects: 2.4.5 (Gosling SR5), 2.5.3 (Hopper SR3)

Issue Links:

• DATAREST-909 Revert Jackson-aware Sort and Pageable translation in Hopper and Gosling release trains

Referenced from: pull request #231

Backported to: 2.5.4 (Hopper SR4), 2.4.6 (Gosling SR6)

2 votes, 7 watchers

[spring-projects-issues]

Oliver Drotbohm commented

I am assuming you're talking about a controller method here? Who's resolving the Pageable in the first place? What does the request look like? What does your setup for PageableHandlerMethodArgumentResolver} look like?

[spring-projects-issues]

Michael Igler commented

Yes, a controller method. The request is "http://localhost:8080/api/languages/9dbf1bf3-3b52-4b88-a356-2f9b6edece04/translations". I have no manual setup for "PageableHandlerMethodArgumentResolver".

[spring-projects-issues]

Michael Igler commented

If I replace @RepositoryRestController through @Controller, then Pageable is initialized with default values (if not set through url-parameters)

[spring-projects-issues]

Oliver Drotbohm commented

Looks like the newly introduced MappingAwarePageableArgumentResolver (to fix DATAREST-883) accidentally drops Pageable instances that don't have no Sort instance attached to it, which unfortunately is the case for the default one being returned from PageableHandlerMethodArgumentResolver

[spring-projects-issues]

Oliver Trosien commented

.. got bitten by that, too. Is there a known work-around?

[spring-projects-issues]

Oliver Drotbohm commented

So far, it looks like the only way is manually checking the instance for null and manually assigning the default then

[spring-projects-issues]

Mark Paluch commented

Another workaround is using DefaultedPageable that contains the resolved Pageable (Our repository controllers use primarily DefaultedPageable)

[spring-projects-issues]

Oliver Drotbohm commented

Fix is in place and snapshots should be available soon. Would be cool if you could give them a spin

[spring-projects-issues]

Michael Igler commented

DefaultedPageable and Hopper-SR4 both fix the problem. Thanx