PUT does not apply new items in nested collection [DATAREST-956]

[spring-projects-issues]

Mathias D opened DATAREST-956 and commented

In the following scenario Parent and Child are entities and Item is either a Embeddable or an Entity. Only Parent has a repository that is also exported.

!http://www.yuml.me/diagram/scruffy/class/%2F%2F Cool Class Diagram, [Parent]->[Child], [Child]<>-*>[Item]!

PUT updates existing items but does not add new items.

Please see this project to reproduce the issue - https://github.com/mduesterhoeft/sdr-put-nested-list. See test ParentRestIntegrationTest#should_add_new_item

---

Here are the requests I am issuing:

• Create parent

POST /parents -> 201
{
    "child": {
        "items": [
          {"some": "test"}]
    }
}

• update parent

PUT /parents/id -> 204
{
    "child": {
        "items": [
          {"some": "test123"},
          {"some": "test1235"}]
    }
}

After the PUT the items collection still has size 1

---

Reference URL: #245

Issue Links:

• DATAREST-958 PUT of Document with List<> fails to add entries post Hopper-SR5+
  ("is duplicated by")

Backported to: 2.6 RC1 (Ingalls), 2.5.6 (Hopper SR6)

[spring-projects-issues]

Oliver Drotbohm commented

I am kind of wondering: do we actually have to issue the complex merge for PUT requests? Shouldn't the general ….readerForUpdate(…) give us exactly the semantics we need?

[spring-projects-issues]

Oliver Drotbohm commented

To answer my own question: no we cannot as causes Jackson to wipe all nested fields. Nested ones annotated with e.g. @JsonIgnore are thus wiped, although they're not intended to be affected by any Jackson interaction

[spring-projects-issues]

Mathias D commented

Ran my test scenario against the latest SNAPSHOT - It works now

[spring-projects-issues]

Oliver Drotbohm commented

👍 And thanks, again!